codeant-ai-for-open-source[bot] commented on code in PR #42339:
URL: https://github.com/apache/superset/pull/42339#discussion_r3772492756
##########
superset/commands/tag/export.py:
##########
@@ -23,33 +23,78 @@
import yaml
from superset.daos.chart import ChartDAO
from superset.daos.dashboard import DashboardDAO
+from superset.daos.tag import TagDAO
from superset.extensions import feature_flag_manager
-from superset.tags.models import TagType
+from superset.tags.models import ObjectType, TagType
+from superset.commands.export.models import ExportModelsCommand
from superset.commands.tag.exceptions import TagNotFoundError
-# pylint: disable=too-few-public-methods
-class ExportTagsCommand:
+class ExportTagsCommand(ExportModelsCommand):
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not require a backward-compatibility wrapper when the legacy export
method has no remaining in-repository callers and the API removal is
intentional after migrating callers to run().
**Applied to:**
- `superset/commands/tag/export.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
