coreforge196 commented on code in PR #42799: URL: https://github.com/apache/superset/pull/42799#discussion_r3772736976
########## superset/migrations/versions/2026-08-07_03-30_5e4f420bcd74_merge_dashboard_folders_with_latest_head.py: ########## @@ -0,0 +1,34 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""merge dashboard folders with latest migration head + +Revision ID: 5e4f420bcd74 +Revises: ('a41c9e7d2f10', 'b8d2f4a6c901') +Create Date: 2026-08-07 03:30:00.000000 + +""" + +revision: str = "5e4f420bcd74" Review Comment: You're right, this merge revision is no longer necessary. I originally added it to resolve the multiple migration heads I encountered while developing the feature, but since this migration has not been released yet, rebasing it directly onto the current master head is cleaner and avoids leaving a stale merge revision. This is my first contribution to Superset, so I appreciate the guidance. I'll remove the merge revision, update the dashboard folder migration to depend on the current master head, and verify the upgrade/downgrade path again. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
