sadpandajoe commented on PR #42821: URL: https://github.com/apache/superset/pull/42821#issuecomment-5287397153
@rusackas both pieces of feedback are addressed: - Pre-commit (ruff-format + mypy) is now green — the DATE_FORMAT assert was reformatted, and a `# type: ignore[import-untyped]` on the `pymysql` fallback import that had been mistakenly removed (mypy's hook doesn't have `types-PyMySQL` installed) is restored. - The `noqa: B010` question: the two fallback tests now build their fake objects with `types.SimpleNamespace` instead of `types.ModuleType`, so no `setattr()`/lint suppression is needed at all (see inline reply). Ready for another look whenever you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
