aminghadersohi commented on PR #42822: URL: https://github.com/apache/superset/pull/42822#issuecomment-5297335779
Reviewed the remaining unresolved Bito thread. It conflated the direct Jinja template-context filter path with the Flask-global form-data fallback: the latter intentionally consumes the plural `filters` key via `convert_legacy_filters_into_adhoc`, while `QueryObject.to_dict()` still retains the singular `filter` key. Real-`QueryObject` regression tests and reviewer execution confirm `filter_values()` and `get_filters()` work. I replied with the technical rationale and resolved the thread. Unresolved review threads: **0**. Review status: **APPROVED**. Failed checks: **0**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
