codeant-ai-for-open-source[bot] commented on code in PR #43205:
URL: https://github.com/apache/superset/pull/43205#discussion_r3788510024
##########
superset/utils/pandas_postprocessing/utils.py:
##########
@@ -86,16 +86,24 @@
PROPHET_TIME_GRAIN_MAP: dict[str, str] = {
Review Comment:
**Suggestion:** The mapping still contains only built-in `TimeGrain` values,
while `ChartDataProphetOptionsSchema` also accepts keys from
`TIME_GRAIN_ADDONS`. A configured custom grain will pass schema validation and
then fail in `prophet()` at the direct map lookup, so either custom grains need
a supported pandas-frequency mapping or Prophet's schema must exclude them.
[api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Forecasting fails for configured custom time grains.
- ⚠️ API validation advertises unsupported forecast values.
- ⚠️ Chart queries return validation errors instead of forecasts.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ee8cebccc684498cb2de9971dea844a5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ee8cebccc684498cb2de9971dea844a5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/utils/pandas_postprocessing/utils.py
**Line:** 87:112
**Comment:**
*Api Mismatch: The mapping still contains only built-in `TimeGrain`
values, while `ChartDataProphetOptionsSchema` also accepts keys from
`TIME_GRAIN_ADDONS`. A configured custom grain will pass schema validation and
then fail in `prophet()` at the direct map lookup, so either custom grains need
a supported pandas-frequency mapping or Prophet's schema must exclude them.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43205&comment_hash=494e397bc695a7af3415e44ef43bbfe667665d76fb767dca8e331c67bcf97f44&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43205&comment_hash=494e397bc695a7af3415e44ef43bbfe667665d76fb767dca8e331c67bcf97f44&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
