bito-code-review[bot] commented on PR #43238: URL: https://github.com/apache/superset/pull/43238#issuecomment-5312561974
<!-- Bito Reply --> The flagged issue is correct. The current implementation in `transformProps.ts` hard-codes the dimension index to `1` when multiple metrics are present, which fails to account for cases where the `stackDimension` is not the second dimension in the `groupby` array. To resolve this, the logic should dynamically determine the index of the `stackDimension` within the `groupby` array. The provided PR diff already implements this fix by calculating `idxSelectedDimension` using `chartProps.rawFormData.groupby.indexOf(stackDimension)` and updating the series grouping logic accordingly. Since the fix is already present in the provided patch, no further action is required for this specific issue. There are no other comments in the PR to address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
