endimonan opened a new pull request, #43256:
URL: https://github.com/apache/superset/pull/43256
### SUMMARY
Fixes #33884.
The dashboard list response and its published OpenAPI schema had drifted
apart, causing generated clients to model relationship fields incorrectly.
This change:
- references `DashboardRestApi.get_list` from the dashboard list operation;
- updates the published dashboard list schema to match the FAB-generated
contract, including array schemas for editors, viewers, and tags;
- exposes the optimized `custom_tags` relationship under its stable public
`tags` name in generated schemas;
- adds focused unit coverage and a causal integration check that compares
the live dashboard schema subset with the published artifact.
The runtime dashboard list payload remains unchanged.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; this is an OpenAPI contract correction.
### TESTING INSTRUCTIONS
```bash
pre-commit run
venv/bin/pytest -q \
tests/unit_tests/dashboards/api_test.py \
tests/unit_tests/views/test_custom_tags_api_mixin.py \
tests/unit_tests/openapi/test_manager.py \
tests/unit_tests/openapi/test_static_spec.py
SUPERSET_CONFIG=tests.integration_tests.superset_test_config \
venv/bin/pytest -q \
tests/integration_tests/base_api_tests.py::TestOpenApiSpec::test_dashboard_list_uses_generated_response_schema
```
The focused unit suite passes with 19 tests. The dashboard APISpec subset
was also generated under both values of `DASHBOARD_LIST_CUSTOM_TAGS_ONLY` and
matched the published six-component subset and endpoint reference. The targeted
integration test requires a provisioned integration metadata database and will
run in CI.
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #33884
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
