msyavuz commented on PR #40815: URL: https://github.com/apache/superset/pull/40815#issuecomment-5317898074
> @msyavuz happy to see this PR open, resolving this at render is the right place for it. I filed https://github.com/apache/superset/issues/43258 about a related case > and I think your hook is close to covering both. > > fetchAllowedValues hits the values endpoint with no filters, so the allow-list picks up > dataset-level RLS but not the viewer's dashboard filters. On 6.1.0 with a matrixified chart > (69 members, all mode so capped at 25): for a restricted user the endpoint returns 2 values > and the intersection nicely collapses the grid to 2 panels. For an admin it returns all ~70, > so nothing gets intersected away and 6 members that do have data still never render — their > narrowing comes from a native filter, not the dataset. Same dashboard, different behaviour > depending on role. > > Would you be open to passing the chart's effective filters into that fetch (or swapping it for > a chart-data query)? Or would you rather keep this focused and I follow up on top? > > Separately, the intersection can't help with members that MAX_ALL_DIMENSION_VALUES = 25 drops > before the fetch — that probably needs its own fix. > > Happy to test a branch, I have a repro. Hey, thanks for the issue. I'll clean this up and push it forward by asking for some reviews. If you already have an approach and a branch i think it's best if i keep this focused and you follow up with your pr on top since i don't have much bandwidth to work on this. Thank you again @mikemazara! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
