aminghadersohi commented on PR #43110: URL: https://github.com/apache/superset/pull/43110#issuecomment-5319490139
Thanks for catching this — addressed in `93a818e1df`. I dropped the third-party `dbapi()` probe, while retaining the type/subclass/name/driver guards. I also added a regression test using a valid SQLAlchemy 2.0-style `DefaultDialect` subclass (with `import_dbapi()` inherited and no `dbapi()`) and assert that its driver is preserved in the available engine specs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
