codeant-ai-for-open-source[bot] commented on code in PR #43271:
URL: https://github.com/apache/superset/pull/43271#discussion_r3799153130
##########
superset-frontend/src/dashboard/components/SliceHeader/index.tsx:
##########
@@ -335,6 +341,19 @@ const SliceHeader = forwardRef<HTMLDivElement,
SliceHeaderProps>(
<CrossFilterIcon iconSize="m" />
</Tooltip>
)}
+ {slice.description && !isExpanded && (
+ <Popover
+ trigger="hover"
+ content={<SliceInfo slice={slice} />}
+ placement="leftBottom"
Review Comment:
**Suggestion:** The new description Popover is rendered in mobile mode, but
its only trigger is `hover`, which is not available on touch devices. Mobile
users therefore see an extra info icon but cannot open the chart description.
Either provide a touch-compatible trigger or suppress this control on mobile.
[logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Mobile users cannot reliably view chart descriptions.
- ⚠️ Description icon remains visible but non-functional.
- ⚠️ Affects mobile dashboard chart consumption.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=55afe80ce3d4466a8e3589e539d33ba4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=55afe80ce3d4466a8e3589e539d33ba4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/dashboard/components/SliceHeader/index.tsx
**Line:** 344:348
**Comment:**
*Logic Error: The new description Popover is rendered in mobile mode,
but its only trigger is `hover`, which is not available on touch devices.
Mobile users therefore see an extra info icon but cannot open the chart
description. Either provide a touch-compatible trigger or suppress this control
on mobile.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43271&comment_hash=bf6e4426f04f037953e10138184bbb4ccd7a0817970b371e969c2015afd64d9d&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43271&comment_hash=bf6e4426f04f037953e10138184bbb4ccd7a0817970b371e969c2015afd64d9d&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
