krmmkr opened a new pull request, #43277:
URL: https://github.com/apache/superset/pull/43277

   ### SUMMARY
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   1. New Filter Card Layout element
   <img width="803" height="1108" alt="image" 
src="https://github.com/user-attachments/assets/c899bf85-b728-45e2-8c5d-760ac104f012";
 />
   <br>
   2. Regular Native filters
   <img width="1760" height="760" alt="image" 
src="https://github.com/user-attachments/assets/daa2a297-e20f-499b-8b45-ac4c5f3d5bc9";
 />
   <br>
   3. Native filters can be chosen when we add Filter Card Component to 
Dashboard Canvas
   <img width="2876" height="1206" alt="image" 
src="https://github.com/user-attachments/assets/f1ae2880-805b-4613-9302-a43320baf2d8";
 />
   
   <br>
   4. Once a Filter is selected (Filter 1 here), they disappear from the 
Vertical / Horizontal Filter bar and show up only in Dashboard canvas. When 
this canvas element is deleted, then they show up in the Global Vertical / 
Horizontal Filter bar.
   <img width="2808" height="1194" alt="image" 
src="https://github.com/user-attachments/assets/5d94f1df-8316-4a2b-8db0-f3882396abfe";
 />
   
   <br>
   
   5. Example Screenshot of Filter 1 not showing up in global filter pane when 
chosen in Canvas Filter
   Image
   <img width="2862" height="1062" alt="image" 
src="https://github.com/user-attachments/assets/60c3ea42-910e-4ab0-8bad-10c3542e1d78";
 />
   
   <br>
   
   ### TESTING INSTRUCTIONS
   Add Filter Card to existing dashboard and select a native filter and native 
filter should move to the dashboard canvas and function as usual superset 
native filter
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: #41498 
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to