ARBS-23 opened a new issue, #43279: URL: https://github.com/apache/superset/issues/43279
### Bug description ### Bug description In Explore (Add/Edit Chart), saving the dataset from the overflow menu → **Edit dataset** with no changes temporarily clears Certified / Warning UI state in the Chart Source dataset editor. After Save: - Certified and Warning **icons** disappear for **Metrics**, **Columns**, and **Calculated columns** - **Certified** field values are cleared for **Columns** and **Calculated columns** - **Metrics** Certified field values still remain - A full page **refresh restores** icons and values (data is persisted; Explore client state is stale) The same temporary clear also happens when **swapping the dataset** on the chart. This is distinct from https://github.com/apache/superset/issues/42704, where a metric Warning *text* stayed blank after reopen from Explore while the warning *icon* remained (persisted value, hydration mismatch). Here icons and some field values vanish immediately after Save, then come back after refresh. ### How to reproduce the bug **Precondition:** Dataset has at least one Metric, Column, and Calculated column with Certified by and/or Warning set (icons visible in Chart Source). 1. Log in as a user with dataset edit permission 2. Go to **Charts** → edit an existing chart, **or** open **Create a new chart** 3. In Chart Source, click `...` beside the dataset name 4. Click **Edit dataset** 5. Click **Save** without changing anything 6. Observe Certified / Warning icons and Certified field values in Chart Source (Metrics / Columns / Calculated columns) 7. Refresh the page **Alternate trigger:** On the same Explore view, swap the chart's dataset (no dataset modal save required). ### Expected behavior Saving the dataset with no changes (or swapping the dataset) should keep Certified / Warning icons and Certified field values visible. Explore should rehydrate the same metadata the GET/refresh path already returns. ### Actual behavior Immediately after Save (or dataset swap): | Item | Icon (Certified / Warning) | Certified field value | |---|---|---| | Metrics | Cleared | **Remains** | | Columns | Cleared | Cleared | | Calculated columns | Cleared | Cleared | After page refresh, icons and values return. No user-visible error in the save flow. ### Screenshots/recordings https://github.com/user-attachments/assets/9472fcd3-5a40-4de9-95ff-cce0f4001277 ### Superset version 6.1.0 ### Python version 3.11 ### Node version 18 or greater ### Browser Chrome ### Additional context - OS: Windows 11 - Role: user with dataset **Edit** permission - Reproduced via monkey test; no dataset field edits are required - Likely Explore client-state / datasource-store refresh after `DatasourceModal` save (and after dataset swap), not a backend wipe: refresh restores the data - Related: https://github.com/apache/superset/issues/42704 (metric Warning rehydration from Explore; different symptom) - Related serialization: https://github.com/apache/superset/pull/39706 (`buildExtraJsonObject` / `warning_markdown`) - Related metric Warning Explore path: https://github.com/apache/superset/pull/43177 - Internal tracker (optional): gigaphoton/fabscape-superset#146 ### Checklist - [x] I have searched Superset docs and Slack and didn't find a solution to my problem. - [x] I have searched the GitHub issue tracker and didn't find a similar bug report. - [x] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
