endimonan commented on PR #43256: URL: https://github.com/apache/superset/pull/43256#issuecomment-5327042544
> ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43256?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > ❌ Patch coverage is `80.00000%` with `1 line` in your changes missing coverage. Please review. ✅ Project coverage is 66.62%. Comparing base ([`13eb47a`](https://app.codecov.io/gh/apache/superset/commit/13eb47a1dabec47560cf7163f420a0e84e1fb6ef?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`adaae34`](https://app.codecov.io/gh/apache/superset/commit/adaae34dad3c0599c816b1c3d856bd10cd2a3c89?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > > [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/43256?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Patch % Lines > [superset/views/custom_tags_api_mixin.py](https://app.codecov.io/gh/apache/superset/pull/43256?src=pr&el=tree&filepath=superset%2Fviews%2Fcustom_tags_api_mixin.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvY3VzdG9tX3RhZ3NfYXBpX21peGluLnB5) 80.00% [0 Missing and 1 partial ⚠️ ](https://app.codecov.io/gh/apache/superset/pull/43256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) > Additional details and impacted files > ```diff > @@ Coverage Diff @@ > ## master #43256 +/- ## > ========================================== > - Coverage 66.63% 66.62% -0.01% > ========================================== > Files 2874 2874 > Lines 163887 163857 -30 > Branches 37816 37812 -4 > ========================================== > - Hits 109199 109170 -29 > + Misses 52544 52541 -3 > - Partials 2144 2146 +2 > ``` > > [Flag](https://app.codecov.io/gh/apache/superset/pull/43256/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Coverage Δ > [hive](https://app.codecov.io/gh/apache/superset/pull/43256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) `38.11% <80.00%> (+<0.01%)` ⬆️ > [mysql](https://app.codecov.io/gh/apache/superset/pull/43256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) `57.79% <80.00%> (-0.01%)` ⬇️ > [postgres](https://app.codecov.io/gh/apache/superset/pull/43256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) `57.82% <80.00%> (-0.01%)` ⬇️ > [presto](https://app.codecov.io/gh/apache/superset/pull/43256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) `40.05% <80.00%> (+<0.01%)` ⬆️ > [python](https://app.codecov.io/gh/apache/superset/pull/43256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) `59.21% <80.00%> (-0.01%)` ⬇️ > [sqlite](https://app.codecov.io/gh/apache/superset/pull/43256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) `57.46% <80.00%> (-0.01%)` ⬇️ > [unit](https://app.codecov.io/gh/apache/superset/pull/43256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) `100.00% <ø> (ø)` > Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. > > [☔ View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43256?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). 📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > > 🚀 New features to boost your workflow: Codecov looks off here because the unit test coverage never actually gets uploaded (the CI job overwrites its own coverage file before the upload step). The flagged lines are all covered by the unit tests in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
