villebro opened a new pull request, #282: URL: https://github.com/apache/superset-kubernetes-operator/pull/282
## Summary Adds `required_pull_request_reviews` to the `main` branch protection in `.asf.yaml` so a PR needs **at least one approving review** before it can be merged — matching the policy on the main [apache/superset](https://github.com/apache/superset) repo. Today `main` requires status checks but no review, so a committer can self-merge. This adds a second-set-of-eyes gate. ```yaml required_pull_request_reviews: dismiss_stale_reviews: false require_code_owner_reviews: false required_approving_review_count: 1 ``` ## Details - **One approval required.** GitHub does not let an author approve their own PR, so this guarantees another committer signs off before merge. It stacks on top of the existing `required_status_checks` (both must be satisfied). - **`require_code_owner_reviews: false`.** This repo has no `CODEOWNERS` file, so code-owner review would be a no-op; any committer's approval satisfies the gate. (The apache/superset repo sets this `true` because it *has* a CODEOWNERS.) ## On the "committers can force-merge blockers" ask There is no `.asf.yaml` mechanism to grant a *per-committer* bypass while keeping the requirement in place. What ASF branch protection does give us: it is **not enforced on repository administrators**, so the **PMC (repo admins) can force-merge** past this requirement in a genuine blocker. Ordinary committers (write access) cannot bypass it — they need the one approval. This is the ASF-normal arrangement and matches how apache/superset operates. If a broader bypass is ever needed, the escape hatch is an admin merge or temporarily relaxing this key. ## Notes - `.asf.yaml` takes effect once merged to the default branch (ASF infra reads it from `main`). - YAML validated locally. --- Opened as a draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
