ASolarers-Rodriguez opened a new pull request, #43304: URL: https://github.com/apache/superset/pull/43304
### SUMMARY `plugin-chart-chord` declares `react: ^19.2.7` in `dependencies`, while the app ships react 18.3.1. npm therefore installs a second, nested copy of React (19.2.8) under the plugin — visible in `package-lock.json` at `plugins/plugin-chart-chord/node_modules/react`. Every sibling plugin declares react as a **peerDependency** instead (e.g. `plugin-chart-echarts`: `^18.3.0`), so the chord plugin is the only one bundling its own React. Besides being inconsistent, this: - creates a latent dual-React hazard (two React copies in one webpack bundle can break hooks/context if the nested copy is ever resolved) - makes SCA scanners (Black Duck, etc.) flag React 19.x advisories against Superset even though the app neither ships nor uses that copy This PR moves react to `peerDependencies: "^18.3.0"` (matching the sibling convention) and removes the now-orphaned nested lockfile entry. `npm ci --dry-run` validates cleanly on node 24.16.0. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — dependency declaration only, no runtime behavior change (the plugin now resolves the same hoisted React the rest of the app uses). ### TESTING INSTRUCTIONS - `npm ci` succeeds; `npm ls react` shows a single react 18.3.1 resolution - Chord chart renders in Explore/dashboards as before ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
