DiggidyDave commented on a change in pull request #8529: Encode feature flags
to JSON pessimistically
URL:
https://github.com/apache/incubator-superset/pull/8529#discussion_r345018580
##########
File path: superset/views/core.py
##########
@@ -3001,7 +3003,7 @@ def sqllab(self):
return self.render_template(
"superset/basic.html",
entry="sqllab",
- bootstrap_data=json.dumps(d, default=utils.json_iso_dttm_ser),
+ bootstrap_data=json.dumps(d,
default=utils.pessimistic_json_iso_dttm_ser),
Review comment:
Feels weird to be passing variant/loosely-typed data to this but I guess
Superset does that a lot so I won't complain much other than to point it out.
:-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
