bito-code-review[bot] commented on PR #43305:
URL: https://github.com/apache/superset/pull/43305#issuecomment-5331375947
<!-- Bito Reply -->
The flagged issue is correct. The current test uses a simplified
`DatabaseSchema` that lacks the `version` field and `ssh_tunnel` validation
required by the production `ImportV1DatabaseSchema`. This allows the test to
pass even if the production code fails to handle these fields correctly.
To resolve this, you should import the production `ImportV1DatabaseSchema`
and update the test to assert that the specific `ValidationError` messages for
missing `uuid` or `ssh_tunnel` fields are present, rather than just checking
for the existence of an exception.
Would you like me to fetch all other comments on this PR to validate and
implement fixes for them as well?
**tests/unit_tests/commands/importers/v1/utils_test.py**
```
def _database_schemas(self) -> dict[str, object]:
from superset.commands.importers.v1.schemas import
ImportV1DatabaseSchema
return {"databases/": ImportV1DatabaseSchema()}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
