sadpandajoe opened a new pull request, #43306:
URL: https://github.com/apache/superset/pull/43306

   ### SUMMARY
   
   Overlapping CRUD list requests could resolve out of order and let an older 
response overwrite the latest filters, count, timestamp, error presentation, 
and loading state. This caused the Recently Archived search to keep showing 
unfiltered rows after the filtered request had returned an empty result.
   
   This change makes `useListViewResource` apply response-side effects only for 
the most recently started request. It adds regression coverage for out-of-order 
success, loading completion, and rejection paths while retaining the existing 
Playwright coverage.
   
   Fixes #43200. This addresses the same failure discussed in #43264 by 
repairing the shared request-ordering behavior rather than removing the browser 
assertion.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Not applicable; this is an asynchronous response-ordering fix with no visual 
redesign.
   
   ### TESTING INSTRUCTIONS
   
   ```bash
   cd superset-frontend
   npm run test -- src/views/CRUD/hooks.test.tsx --maxWorkers=2
   npx oxlint --config oxlint.json --quiet src/views/CRUD/hooks.ts 
src/views/CRUD/hooks.test.tsx
   npx oxfmt --check src/views/CRUD/hooks.ts src/views/CRUD/hooks.test.tsx
   ```
   
   The unit tests use controlled promises to resolve an older request after a 
newer request and verify that stale success, error, and loading completions 
cannot mutate the latest state.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: #43200
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to