bito-code-review[bot] commented on PR #43202: URL: https://github.com/apache/superset/pull/43202#issuecomment-5332536828
<!-- Bito Reply --> The suggestion to remove these functions and their call sites is reasonable, as they currently act as identity functions and no-ops. If they are retained for out-of-tree compatibility, adding a DeprecationWarning is an appropriate way to make the contract explicit and warn future contributors. I recommend proceeding with the cleanup if the internal usage is fully removed, or adding the warnings if external compatibility is a requirement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
