bito-code-review[bot] commented on code in PR #40954:
URL: https://github.com/apache/superset/pull/40954#discussion_r3807894635
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/types.ts:
##########
@@ -64,6 +64,14 @@ export type EchartsTimeseriesFormData = QueryFormData & {
forecastSeasonalityDaily: null;
forecastSeasonalityWeekly: null;
forecastSeasonalityYearly: null;
+ anomalyDetectionEnabled: boolean;
+ anomalyDetectionMethod: string;
+ anomalyDetectionRollingWindow: number;
+ anomalyDetectionSensitivity: number;
+ anomalyDetectionConfidenceInterval: number;
+ anomalyDetectionSeasonalityYearly: null | boolean | number;
+ anomalyDetectionSeasonalityWeekly: null | boolean | number;
+ anomalyDetectionSeasonalityDaily: null | boolean | number;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Type mismatch: forecast vs anomaly seasonality</b></div>
<div id="fix">
The forecast seasonality properties (lines 64-66) are typed as `null` only,
but analogous anomalyDetectionSeasonality* properties (lines 72-74) correctly
use `null | boolean | number`. Both have identical UI controls (`SelectControl`
with `freeForm: true` and `validateSeasonality` that accepts
null/boolean/number). Align types for consistency.
</div>
</div>
<small><i>Code Review Run #3b039e</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
