sadpandajoe opened a new pull request, #43314:
URL: https://github.com/apache/superset/pull/43314
### SUMMARY
When a Time-Series chart's Legend Type is set to Plain (List) and enough
grouped
dimensions are combined to produce many legend entries, the legend can
render on
top of the chart's plot area instead of the chart displaying properly. The
chart's
own legend-layout estimator already computed how much vertical/horizontal
margin a
Plain legend actually needs, but that computed margin was clamped to a fixed
fraction of the chart's height/width — a legend with more entries than the
clamp
allowed still rendered every row (nothing paginates or hides a Plain legend's
entries), so entries beyond the clamped margin painted over the plot grid.
This change makes the Timeseries chart reserve the full margin its own
estimator
computes, bounded only by a small fixed minimum plot space so the chart area
is
never fully consumed, and correctly accounts for the other fixed grid padding
(top offset, zoomable bottom/left padding, axis-title offsets) so the
reserved
space matches what ECharts actually lays out. It does not change how the
legend
type itself is resolved — an explicit Plain/List selection is still always
honored, never silently switched to a scrolling legend. The change is scoped
to
the Timeseries chart plugin; the shared legend-layout helper's behavior for
other
chart types (Mixed Timeseries, Gantt, Pie, Funnel, Radar, Bubble, Graph) is
unchanged.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
_Attached separately after live verification._
### TESTING INSTRUCTIONS
1. Create a Time-Series Line Chart using a dataset with two grouped
dimensions
whose combination produces many series (dozens or more) — e.g. two
categorical
columns with a handful of distinct values each.
2. Under the Customize tab, set Legend Type to Plain and Legend Orientation
to Top
(the default).
3. Create/update the chart.
4. Verify the legend no longer overlaps the chart's plot area — the plot area
shrinks to make room for the full legend instead.
5. Verify a chart with only a few legend entries is unaffected (legend still
reserves only the minimal padding it needs).
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
