bito-code-review[bot] commented on PR #43319: URL: https://github.com/apache/superset/pull/43319#issuecomment-5338213424
<!-- Bito Reply --> The flagged performance issue is correct. The current implementation of the dataset API exposes certification and warning metadata by dynamically accessing model properties, which triggers repeated JSON parsing of the `extra` field for every column and metric during serialization. To resolve this, you should parse the `extra` metadata once at the beginning of the serialization process and cache the resulting dictionary. You can then derive the certification and warning fields from this cached mapping for all columns and metrics, avoiding redundant parsing. Would you like me to fetch all other comments on this PR to validate and implement fixes for them as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
