Lothnic opened a new pull request, #43333: URL: https://github.com/apache/superset/pull/43333
### SUMMARY Resizing modals from top or left edges (Drill by, Drill to detail, View as table) produced inverted-corner behavior and drift because `react-draggable` and `re-resizable` both tried to control position independently. Two changes in `Modal.tsx`: 1. **Config merge fix**: Merge caller `resizableConfig` with defaults so callers that only set `minHeight`/`minWidth`/`defaultSize` don't silently enable all 8 resize handles (`top`, `left`, `topLeft`, etc.) 2. **Controlled Draggable**: Switch `Draggable` to controlled mode and sync its position state with `re-resizable`'s `onResize` callback, so resizing from top/left repositions the modal to anchor the opposite corner ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF _Before: Dragging from top-left corner resizes from bottom-right instead, and resizing along one axis causes drift_ _After: Top-left corner correctly anchors the bottom-right, and resize direction matches the handle being dragged_ ### TESTING INSTRUCTIONS 1. Open a chart on a dashboard, right-click → "Drill by" 2. Try resizing from the top-left corner — it should now correctly resize from that corner (bottom-right stays fixed) 3. Try resizing from the left edge — modal should stay anchored on the right 4. Existing bottom/right resize behavior should be unchanged ### ADDITIONAL INFORMATION - Has associated issue: #43320 - Required feature flags: None - No DB migration - Added 9 new tests in `Modal.test.tsx` (all passing) - All existing Modal-related tests pass (57/57) ### CHECKLIST - [x] CI checks pass - [x] Tests added - [x] PR title follows conventions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
