gabotorresruiz commented on PR #43336: URL: https://github.com/apache/superset/pull/43336#issuecomment-5346865497
Heads up: removing the guest guard here exposes an `AttributeError` on `g.user.id` in `export_xlsx` (`GuestUser` has no `id` attribute), so embedded guests get a 500 `Fatal error` instead of an export. Reproduced on a staging deployment carrying this branch's changes. I opened #43340 against this branch with the fix (guest token passed to the task, guest user reconstructed via `get_guest_user_from_token` so RLS claims hold in the worker, shared lock slot 0 for guests) plus a unit test, so it can be merged into this PR before this lands on master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
