AurimasNav commented on PR #43329: URL: https://github.com/apache/superset/pull/43329#issuecomment-5347118511
On the codecov report (patch 0%, 5 lines): the new lines **are** tested — the report appears to be an artifact of how the unit-test job assembles coverage, not missing tests. Evidence the tests ran: the `junit-results-current` artifact of run [32229167129](https://github.com/apache/superset/actions/runs/32229167129) contains all three new tests, passing, in `junit-unit.xml`: - `test_create_auth_provider_fails_closed_when_custom_factory_raises` - `test_create_auth_provider_passes_through_custom_factory_config_error` - `test_create_auth_provider_uses_custom_factory_result` Likely cause: the `unit-tests` job runs three pytest-cov invocations in sequence — the full unit suite (`--cov=superset`), then the two `--cov-fail-under=100` gates for `superset/sql/` and `superset/semantic_layers/`. With no `parallel` mode in `.coveragerc` and no `--cov-append`, each invocation erases `.coverage` at session start, so the file the codecov step turns into `coverage.xml` holds only the *last* run's data (`semantic_layers`). Any PR line outside `superset/sql/` or `superset/semantic_layers/` would report as uncovered by this flag regardless of its tests. Happy to adjust if maintainers read it differently, but I don't think there's a coverage gap to fix in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
