Vitor-Avila commented on PR #43309: URL: https://github.com/apache/superset/pull/43309#issuecomment-5347903627
> On gating it behind the checkbox — I think that's the correct narrow fix, and the plumbing already exists: impersonate_user is part of the validate-parameters payload (DatabaseValidateParametersSchema, superset/databases/schemas.py#L481) and the full properties dict is handed to validate_parameters unmodified (superset/commands/database/validate.py#L80). So validation can read the real setting and pass subject only when impersonation is on, which makes it mirror execution exactly instead of guessing. That change is only coherent alongside dropping the forced impersonate_user = true at index.tsx#L1051, otherwise the flag is always true and nothing changes — which also matches your recollection that you couldn't disable the checkbox for GSheets. I'll restructure the PR that way unless you'd rather see it split into backend and frontend changes. One limitation here is that the checkbox only shows up to be changed **_after_** the connection is created. So you might need to make the URL check loose, which is not great. > Even if SA + DWD is deprecated, surfacing the real error rather than a misleading one seems worth doing on its own, and I'm happy to narrow this PR to just that if the broader behavior change should wait for a SIP. Oh, I meant to say that SA + DWD is deprecated + the checkbox is unchecked (and no longer works for SA auth) + queries always use SA only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
