SEPURI-SAI-KRISHNA commented on PR #42410: URL: https://github.com/apache/superset/pull/42410#issuecomment-5351112739
Rebased onto master to clear the conflict with #42927. The collision was purely textual: both that PR and this one append tests to the end of `tests/unit_tests/queries/query_object_test.py`, off the same anchor. Both sets are kept; the imports merged cleanly. The two changes are complementary rather than overlapping. #42927 drops options an operation no longer accepts, and deliberately leaves a missing or unknown `operation` untouched: > `# A missing or unknown operation is left untouched, so that exec_post_processing reports it as InvalidPostProcessingError.` That is the error this PR fixes, it was interpolating `type=operation` into a `%(operation)s` placeholder, so the message raised at render time instead of naming the operation. So #42927 routes those cases to `exec_post_processing`, and this PR makes the message it produces correct. Both of this PR's tests still pass unchanged against the merged tree. Verified after the merge: 369 passed across `pandas_postprocessing`, `queries` and `common`; 9 of those are the post-processing tests, 2 from this PR and 7 from #42927. ruff 0.9.7 clean, formatting unchanged, pylint 9.71/10 with the four remaining findings all pre-existing on master (identical codes, same functions), the score is marginally above master's 9.69. @rusackas thanks for merging master in on the 15th, flagging this since your approval predates the conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
