SEPURI-SAI-KRISHNA opened a new pull request, #43357:
URL: https://github.com/apache/superset/pull/43357
### SUMMARY
Two issue templates declare labels that no longer exist in the repository, so
GitHub applies nothing and every issue filed through them arrives unlabelled.
| file | declares | exists? | live label |
| --- | --- | --- | --- |
| `.github/ISSUE_TEMPLATE/bug-report.yml` | `bug` | no | `#bug` |
| `.github/ISSUE_TEMPLATE/cosmetic.md` | `cosmetic-issue` | no |
`#bug:cosmetic` |
| `.github/ISSUE_TEMPLATE/sip.md` | `sip` | **yes** | unchanged |
The labels were renamed and the templates were not updated. The surviving
`!deprecated-label:bug` tombstone records the first rename. That the
replacements are the names actually in use is not a guess -- `#bug` carries
2037 issues and PRs, `#bug:cosmetic` carries 338.
This fails quietly, which is what makes it worth fixing: the issue is
created,
no label is applied, and nothing is surfaced to the author -- who in the
common
case is not a committer and cannot add labels themselves. So bug reports
filed
through the template are invisible to any label-based triage queue.
Found while filing #43356, which was created through the bug report template
and carries no `#bug` label.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A -- repository metadata only.
### TESTING INSTRUCTIONS
The label names can be checked against the repository directly:
```bash
gh api repos/apache/superset/labels --paginate --jq '.[].name' | grep -ixE
'#?bug|cosmetic-issue|#bug:cosmetic|sip'
```
`bug` and `cosmetic-issue` return nothing; `#bug`, `#bug:cosmetic` and `sip`
are all present.
The quoting matters and is easy to get wrong in review: an unquoted `#`
opens a
YAML comment, so `labels: [#bug]` is a parse error rather than a label. Both
values here are quoted.
```bash
python3 -c 'import yaml; print(yaml.safe_load("labels: [\"#bug\"]"))'
# {'labels': ['#bug']}
```
End to end, the template can only be confirmed by filing an issue, since
GitHub
resolves template labels at creation time.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### CHECKLIST
- [ ] CI checks pass
- [ ] Tests added/updated
- [ ] Documentation updated
- [x] PR title follows conventions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
