vhogberg commented on code in PR #43112:
URL: https://github.com/apache/superset/pull/43112#discussion_r3819716743
##########
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts:
##########
@@ -244,11 +247,19 @@ export default function transformProps(
if (!legendSort) return 0;
return legendSort === 'asc' ? a.localeCompare(b) : b.localeCompare(a);
});
+ const isHorizontalLegend = [
+ LegendOrientation.Top,
+ LegendOrientation.Bottom,
+ ].includes(legendOrientation);
+ const resolvedLegendMargin =
Review Comment:
Funnel has no legend type control, so it's always scroll and not list, which
shows a pager arrow instead of wrapping to another row. Let me know if you'd
still prefer another implementation though!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
