sadpandajoe opened a new pull request, #43366: URL: https://github.com/apache/superset/pull/43366
### SUMMARY The nightly all-files pre-commit workflow fails on master for two independent deterministic reasons: - MyPy rejects the semantic-layer `column_formats` mapping because its inferred `dict[str, str]` type is invariant with the `ExplorableData` field's `dict[str, str | None]` type. - Oxfmt 0.63 rewrites four untouched frontend files, leaving the scheduled formatter check dirty. This change explicitly annotates the mapping with the public API value type and applies the repository-pinned formatter to the four files reported by the failed workflow. The separate nightly bundle-size failure is already addressed by #43251 and is intentionally not duplicated here. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; CI-only type and formatting fixes. ### TESTING INSTRUCTIONS - `pre-commit run mypy --all-files` — passed, including 2,554 main source files. - `npx oxfmt --check` on the four changed frontend files — passed. - `npx oxlint --deny-warnings` on the four changed frontend files — passed. - Focused Jest suites for `FixedOrMetricControl`, `DatasetPanel`, and `DatasetPanelWrapper` — 17/17 tests passed with `--maxWorkers=2`. - `ruff check superset/semantic_layers/models.py` and Python compile check — passed. - `pre-commit run --all-files` was executed before push. The relevant hooks passed; the complete local run remained non-green because the fresh worktree lacked Docs ESLint dependencies and built TypeScript package declarations, and repository-wide Ruff exposed unrelated baseline findings. - Staged-file `pre-commit run` was also executed. All applicable hooks passed except frontend type-check, which requires the same missing package build outputs; PR CI is the authoritative full-build verification. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
