sadpandajoe commented on code in PR #37015:
URL: https://github.com/apache/superset/pull/37015#discussion_r3826870710
##########
scripts/check-env.py:
##########
@@ -68,7 +70,7 @@ def check_version(self) -> str:
if ideal_min <= version_number <= ideal_max:
return "✅ Ideal"
- elif supported_min <= version_number:
+ elif supported_min <= version_number <= supported_max:
Review Comment:
This makes Node 24.16.0—the version required by
`superset-frontend/package.json`—report as unsupported and makes the
environment check exit 1. Should the supported range be updated alongside this
bound?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
