sadpandajoe commented on code in PR #37479:
URL: https://github.com/apache/superset/pull/37479#discussion_r3827005499
##########
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx:
##########
@@ -508,7 +508,7 @@ export default function PluginFilterSelect(props:
PluginFilterSelectProps) {
name={formData.nativeFilterId}
allowClear
allowNewOptions={!searchAllOptions && creatable !== false}
- allowSelectAll={!searchAllOptions}
+ allowSelectAll={multiSelect}
Review Comment:
With dynamically searched filters, the client initially has at most 1,000
values. This makes "Select all" create an `IN` filter for that subset and
exclude matching values that have not been loaded. Should bulk selection stay
disabled until the full result set is available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
