bito-code-review[bot] commented on PR #43374:
URL: https://github.com/apache/superset/pull/43374#issuecomment-5365933939
<!-- Bito Reply -->
The flagged issue is correct. In the test
`test_is_error_survives_structured_content_stripping`, the assertion `assert
"[REDACTED]" in text` at line 131 references the variable `text`, which is not
defined in this test method. This will indeed cause a `NameError`.
To resolve this, you should remove the misplaced assertion, as it appears to
be a copy-paste error from the preceding `test_client_facing_text_is_sanitized`
test.
```python
assert result.structured_content is None
assert result.is_error is True
```
I have validated the issue and proposed the fix. Would you like me to check
the other comments on this PR and implement fixes for them as well?
**tests/unit_tests/mcp_service/test_middleware.py**
```
assert result.structured_content is None
assert result.is_error is True
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
