sha174n commented on PR #43273: URL: https://github.com/apache/superset/pull/43273#issuecomment-5368855702
Heads up that this may not be a no-op: the project currently pins sqlalchemy<2 (1.4.x), and on 1.4 future=True opts into 2.0-style connection/transaction/commit semantics. Removing it on the live paths (e.g. streaming_export/base.py, db_engine_specs/gsheets.py, migrations/shared/catalogs.py) reverts them to legacy 1.x behavior, which the test suite won't necessarily surface. Could you clarify the intended behavior here (and whether this is prep for the SQLAlchemy 2.0 work) rather than a chore, and scope it to the paths you actually mean to change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
