rusackas commented on PR #39226: URL: https://github.com/apache/superset/pull/39226#issuecomment-5371266003
@sha174n added a unit test for the host `colors.ts` wiring so the coverage gap's closed now. On the structural check, I actually tried writing one: a compile-time `extends` assertion between the real registry type and `CategoricalSchemeRegistryLike` fails to compile even today, because TS treats the two `ColorSchemeGroup` enums as nominally distinct despite matching string values. Making it pass would mean carving `group` out of the check somehow, which feels like more machinery than the `as` cast tradeoff is worth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
