bito-code-review[bot] commented on PR #43396:
URL: https://github.com/apache/superset/pull/43396#issuecomment-5372416942
<!-- Bito Reply -->
The flagged issue is correct. Hardcoding `10001` in the test makes it
brittle because it ignores the configurable `MAX_PROPHET_PERIODS` limit, which
could lead to false negatives or unnecessary performance costs if the
environment configuration is changed.
To resolve this, you should import the configuration and use it to derive
the test input. For example:
```python
from superset.extensions import appbuilder
# ... inside the test ...
max_periods = appbuilder.app.config.get("MAX_PROPHET_PERIODS", 10000)
over_limit_value = max_periods + 1
# Use over_limit_value in your test assertion
```
I have checked the available PR context, and there are no other comments or
suggestions to address at this time. Would you like me to proceed with any
other tasks?
**tests/unit_tests/pandas_postprocessing/test_prophet.py**
```
from superset.extensions import appbuilder
# ... inside the test ...
max_periods = appbuilder.app.config.get("MAX_PROPHET_PERIODS", 10000)
over_limit_value = max_periods + 1
# Use over_limit_value in your test assertion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
