sadpandajoe commented on PR #43137: URL: https://github.com/apache/superset/pull/43137#issuecomment-5376063549
Thanks for the review — this is already addressed as of , a follow-up commit pushed after the initial fix (it looks like it may have landed after you started reviewing). The edit-mode selector now keys off `creationMethod` the same way the save payload does: ```ts const isChartReport = creationMethod === CreationMethod.Charts; const resourceType = isChartReport ? CreationMethod.Charts : CreationMethod.Dashboards; const resourceId = isChartReport ? chart?.id : dashboardId; return reportSelector(state, resourceType, resourceId) || EMPTY_OBJECT; ``` (`superset-frontend/src/features/reports/ReportModal/index.tsx`, current HEAD). This closes exactly the case you described — a chart opened from a dashboard no longer resolves/edits the dashboard-scoped report — and is covered by a regression test seeding both a dashboard-scoped and chart-scoped report. Let me know if you're still seeing the old behavior on the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
