sha174n commented on PR #43389:
URL: https://github.com/apache/superset/pull/43389#issuecomment-5382019831
The per-object access checks on the detail/views/runtime-schema endpoints
and the editorship checks on update/delete look correct and fail-closed. Two
items against the original scope before this is fully complete: (1)
_serialize_layer still returns the fully decrypted configuration to any caller
who passes the access check; since that blob holds the datasource connection
settings, it would be worth masking the sensitive fields on serialization the
way the Database API already does, rather than returning them in cleartext. (2)
get_list, get, and runtime_schema do not carry the
is_feature_enabled("SEMANTIC_LAYERS") guard that structure/views/delete do, so
those routes stay reachable when the feature is off and the flag handling is
inconsistent across the API. Worth adding for parity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
