bito-code-review[bot] commented on PR #43428:
URL: https://github.com/apache/superset/pull/43428#issuecomment-5382344784
<!-- Bito Reply -->
The flagged issue is correct. The current implementation in
`transformProps.ts` unconditionally sets `splitLine.show = false` on the x-axis
when `gridlines` is false, which incorrectly overrides temporal axes that
should not be affected by this control. To resolve this, you should restrict
the override to numeric x-axis types by checking `xAxisType`.
Here is the corrected implementation for
`superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts`:
```typescript
minorTick: { show: minorTicks },
axisTick: { show: axisTicks ? 'auto' : false },
...(gridlines || xAxisType !== AxisType.Numeric ? {} : { splitLine: {
show: false } }),
minInterval:
xAxisType === AxisType.Time && resolvedTimeGrain && !forceMaxInterval
```
I have checked the other comments on this PR, and there are no additional
review comments to address. Would you like me to perform any further analysis?
**superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts**
```
minorTick: { show: minorTicks },
axisTick: { show: axisTicks ? 'auto' : false },
...(gridlines || xAxisType !== AxisType.Numeric ? {} : { splitLine: {
show: false } }),
minInterval:
xAxisType === AxisType.Time && resolvedTimeGrain && !forceMaxInterval
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
