sadpandajoe commented on code in PR #43429:
URL: https://github.com/apache/superset/pull/43429#discussion_r3837083595
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx:
##########
@@ -283,6 +283,8 @@ const FilterValue: FC<FilterValueProps> = ({
formData: newFormData,
force: fromCache ? false : shouldRefresh,
ownState: filterOwnState,
+ // 202 is handled below via waitForAsyncData.
+ enableAsyncMode: true,
Review Comment:
A dashboard set to force async off still enables this request whenever the
deployment default is on, because this path never receives the dashboard
override that `exploreJSON` passes to `resolveAsyncMode`. That makes filter
values use a 202/polling flow while the dashboard's charts stay synchronous.
Could this request receive the same override (and be covered for both override
directions)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
