bito-code-review[bot] commented on PR #43432:
URL: https://github.com/apache/superset/pull/43432#issuecomment-5387000528
<!-- Bito Reply -->
The flagged issue is correct. The PR replaces `granularity_sqla` with
`granularity` in various configuration files, but the backend logic that
rebuilds queries from saved form data (specifically `_columns_and_metrics`) is
not yet updated to recognize the new `granularity` key. This causes the time
column to be dropped in certain query paths, leading to the loss of trendline
time series.
To resolve this, you should update the query rebuilding logic to check for
`granularity` if `granularity_sqla` is missing. Since I do not have access to
the specific file containing the `_columns_and_metrics` logic, I recommend
searching your codebase for that attribute and adding a fallback:
```python
# Example of the required logic update
granularity = form_data.get("granularity") or
form_data.get("granularity_sqla")
```
There are no other comments in the provided PR review data to address.
**superset/examples/birth_names.py**
```
granularity = form_data.get("granularity") or
form_data.get("granularity_sqla")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
