villebro commented on PR #43436:
URL: https://github.com/apache/superset/pull/43436#issuecomment-5387844728
Thanks — both bots flagged the same `waitersByTaskId` null-pointer (a
`realtime:*` message arriving while `GLOBAL_ASYNC_QUERIES` is off, since the
shared socket connects on `WEBSOCKET_ENABLED` alone). Fixed in 0991301bd1 by
initializing `waitersByTaskId = new Map()` eagerly at declaration rather than
only inside `init()` after the flag gate — so `applyStatus` always finds a map
and no-ops when there are no waiters, with no per-call guard needed. Regression
test added ("a tier-2 message is a no-op when async queries are disabled").
Heads up that this PR also grew a maintainer-requested feature since the
initial review: task rows now live-update on **intermediate** transitions
(IN_PROGRESS / progress / abort), not just completion. Nudges are emitted
post-commit from the internal status/update/cancel commands, and the nudge now
carries the integer `id` (FAB's default converter can't build an `in` filter on
a `UUIDType` column, so the batched refetch keys on `id`); the refetch debounce
was bumped to 1s to coalesce the higher volume.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
