russlan23 opened a new pull request, #43439: URL: https://github.com/apache/superset/pull/43439
### SUMMARY `createSmartNumberFormatter` treated `id || signed` as the ternary condition, so any supplied formatter ID was replaced with a built-in smart-number ID. This preserves a supplied ID and only selects the signed or unsigned default when `id` is absent. Regression coverage verifies custom IDs with both signed modes. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; this fixes formatter metadata without changing UI rendering. ### TESTING INSTRUCTIONS - `npm test -- packages/superset-ui-core/test/number-format/factories/createSmartNumberFormatter.test.ts --runInBand` - 23 passed - `npx tsc --build packages/superset-ui-core/tsconfig.json` - `npx oxfmt <changed files> --check` - `npx oxlint --config oxlint.json --quiet <changed files>` ### ADDITIONAL INFORMATION - [x] Has associated issue: Fixes #43430 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
