codeant-ai-for-open-source[bot] commented on code in PR #43468:
URL: https://github.com/apache/superset/pull/43468#discussion_r3845360084
##########
superset/examples/birth_names.py:
##########
@@ -287,7 +287,7 @@ def create_slices(tbl: SqlaTable) -> tuple[list[Slice],
list[Slice]]:
viz_type="table",
params=get_slice_json(
defaults,
- groupby=["name"],
+ columns=["name"],
Review Comment:
**Suggestion:** The chart form data now stores dimensions only in `columns`,
but aggregate-mode frontend query extraction intentionally ignores `columns`
and reads dimensions from `groupby`; the timeseries builder and chart renderers
also consume `formData.groupby`. As a result, the affected pie, table, area,
and timeseries charts are queried without their intended name/gender/state
dimensions and render collapsed or incorrectly labeled results. Preserve the
frontend-compatible `groupby` field or update the complete frontend migration
path, rather than changing only the saved fixture key. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Generated Birth Names table charts lose their name grouping.
- ⚠️ Example dashboard tables can show collapsed aggregate results.
- ⚠️ Table rendering loses grouping-based labels and interactions.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ea4f9a297b534460a414d7cc2eb12ae3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ea4f9a297b534460a414d7cc2eb12ae3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/examples/birth_names.py
**Line:** 290:290
**Comment:**
*Api Mismatch: The chart form data now stores dimensions only in
`columns`, but aggregate-mode frontend query extraction intentionally ignores
`columns` and reads dimensions from `groupby`; the timeseries builder and chart
renderers also consume `formData.groupby`. As a result, the affected pie,
table, area, and timeseries charts are queried without their intended
name/gender/state dimensions and render collapsed or incorrectly labeled
results. Preserve the frontend-compatible `groupby` field or update the
complete frontend migration path, rather than changing only the saved fixture
key.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43468&comment_hash=59e485f413109c3dafb7419c5b95f3c2d48a1c0132cde4ea8c8a8acf1a20f0e1&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43468&comment_hash=59e485f413109c3dafb7419c5b95f3c2d48a1c0132cde4ea8c8a8acf1a20f0e1&reaction=dislike'>👎</a>
##########
superset/examples/world_bank.py:
##########
@@ -190,7 +190,7 @@ def create_slices(tbl: BaseDatasource) -> list[Slice]:
defaults,
viz_type="table",
metrics=["sum__SP_POP_TOTL"],
- groupby=["country_name"],
+ columns=["country_name"],
Review Comment:
**Suggestion:** The affected World Bank charts likewise provide their
dimensions only through `columns`, while the timeseries and treemap builders
and renderers read aggregate dimensions from `groupby`; aggregate query-field
extraction also ignores `columns`. Consequently, Growth Rate, World's Pop
Growth, Rural Breakdown, and Treemap can query ungrouped data and lose their
country/region hierarchy or series labels. Keep the frontend-required grouping
field or migrate the consumers together with these fixtures. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ World Bank country table loses country-level grouping.
- ⚠️ Generated dashboard results collapse into aggregate rows.
- ⚠️ Country labels and table interactions become incorrect.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3a41a6da50164e1aa0fe1e7443563882&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3a41a6da50164e1aa0fe1e7443563882&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/examples/world_bank.py
**Line:** 193:193
**Comment:**
*Api Mismatch: The affected World Bank charts likewise provide their
dimensions only through `columns`, while the timeseries and treemap builders
and renderers read aggregate dimensions from `groupby`; aggregate query-field
extraction also ignores `columns`. Consequently, Growth Rate, World's Pop
Growth, Rural Breakdown, and Treemap can query ungrouped data and lose their
country/region hierarchy or series labels. Keep the frontend-required grouping
field or migrate the consumers together with these fixtures.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43468&comment_hash=f6b5a17217312cf77ec8be233995992c976f9a82de0c795ad4698635c17f7568&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43468&comment_hash=f6b5a17217312cf77ec8be233995992c976f9a82de0c795ad4698635c17f7568&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
