rusackas commented on PR #43058: URL: https://github.com/apache/superset/pull/43058#issuecomment-5398587835
@sha174n CodeAnt's catalog thread above is accurate, not a false positive: `filter_by(catalog=None)` builds a real `IS NULL` predicate, but `import_from_dict`'s own matching drops a None field entirely, so a twin with a non-null default catalog still gets updated there while missing this probe. Should the probe use that same None-omitting logic instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
