justinpark opened a new pull request, #43487:
URL: https://github.com/apache/superset/pull/43487
### SUMMARY
`DashboardV2Page.ts`'s `BUILDING_BLOCKS_TAB` selector (`text=Building
blocks`) matches a label that no longer exists. #43262 ("support progressive
widget schema disclosure") renamed the editor panel's palette tab from
"Building blocks" to "Widgets" (`BuildingBlockView.tsx` → `WidgetView.tsx`,
`registerBuildingBlocks.ts` → `registerBuiltInWidgets.ts`, etc. —
`EditorPanel.tsx` now renders `label: t('Widgets')`), but the Playwright page
object's selector was never updated to match.
`DashboardV2Page.showPalette()` — used by `filters.spec.ts`,
`layout-regressions.spec.ts`, `reposition-and-resize.spec.ts`, and
`split.spec.ts` under `playwright/tests/experimental/dashboard-v2/` — has been
timing out in CI ever since, waiting 30s for a `text=Building blocks` locator
that can't match anything on the page.
This renames `BUILDING_BLOCKS_TAB` → `WIDGETS_TAB` (value `text=Widgets`)
and updates the one call site and its doc comment. No behavior change beyond
fixing the selector — everything else in the page object is untouched.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable — this only touches a test helper's locator string, not app
UI.
### TESTING INSTRUCTIONS
```
INCLUDE_EXPERIMENTAL=true npm run playwright:test \
playwright/tests/experimental/dashboard-v2/filters.spec.ts \
playwright/tests/experimental/dashboard-v2/layout-regressions.spec.ts \
playwright/tests/experimental/dashboard-v2/reposition-and-resize.spec.ts \
playwright/tests/experimental/dashboard-v2/split.spec.ts
```
Before this change, all four spec files time out at the first
`showPalette()`/`placeBlockByClick()` call after the initial block placement.
After this change, they should get past that step (this PR doesn't claim to fix
every assertion further into each spec — only the selector mismatch blocking
all of them at the same step).
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
