rusackas commented on PR #43060: URL: https://github.com/apache/superset/pull/43060#issuecomment-5398573638
Code looks solid, fail-closed on an ambiguous `set_config` name is the right call, and the non-literal / opaque DO-block cases are both covered with real tests. Only thing blocking is GitHub shows conflicts with `master` now, needs a rebase before this can merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
