rusackas opened a new pull request, #43495:
URL: https://github.com/apache/superset/pull/43495

   ### SUMMARY
   The `SQLALCHEMY_WARN_20` env var in `superset-python-unittest.yml` only had 
effect
   under SQLAlchemy 1.4, where it promoted 2.0-migration deprecation warnings to
   errors. The SQLAlchemy 2.0 bump landed in #42803 and has been stable on 
master
   since; under SQLAlchemy 2.0.52 this flag is a silent no-op. Removing it as 
the
   cleanup step called out in the migration battleplan (discussion #40273).
   
   ### TESTING INSTRUCTIONS
   CI itself is the test — unit tests should behave identically with the flag 
removed
   since it does nothing under the currently-pinned SQLAlchemy version.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to