abolfazlmadanii commented on issue #36765:
URL: https://github.com/apache/superset/issues/36765#issuecomment-5406937093

   I'd like to pick this up.
   
   [#36777](https://github.com/apache/superset/pull/36777) was pointed at the 
right symptom (`is_test_user IN (0)`), but it didn't fully fix the dialect 
issue: Hive/Databricks still bind Python `True`/`False` as integers, so the SQL 
becomes `col = 1` and you get `DATATYPE_MISMATCH.BINARY_OP_DIFF_TYPES`. That 
also hits `EQUALS` / `NOT_EQUALS` through `handle_comparison_filter`, not only 
`IN`.
   
   Plan: Databricks engine-spec overrides that use SQLAlchemy `true()` / 
`false()` so the compiler emits `TRUE`/`FALSE` keywords, covering native-filter 
`IN` and comparison filters. Tests will assert the compiled SQL, not just the 
Python expression.
   
   I'll open a PR against this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to