EnxDev commented on code in PR #43453:
URL: https://github.com/apache/superset/pull/43453#discussion_r3850899571
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx:
##########
@@ -2140,7 +2178,7 @@ function DatasourceEditor({
}}
expandFieldset={
<FormContainer>
- <Fieldset compact>
+ <Fieldset compact renderWarning={renderMetricFormatWarning}>
Review Comment:
Yes, intentional — per the PR description, this only warns at dataset-metric
authoring time; chart rendering is deliberately unchanged. Extending the check
into Explore's Number format control (where y_axis_format/number_format can
override d3format anyway) would be a reasonable follow-up, but it's a separate
scope from this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
